You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went back to review the spec and was reminded that EDTF is an extension of ISO 8601, which means that the base rules of that spec still apply. Although EDTF only specifies a required number of year digits for significant digits notation, the base rules for ISO 8601 do require four digits.
So, mea culpa, those three-digit years are invalid.
What does this Pull Request do?
Puts back check for four+ digit years.
What's new?
Does this change require documentation to be updated? No
Does this change add any new dependencies? No
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? No
Could this change impact execution of existing code? Not unless you added some three-digit years since the error was introduced.
It seems very odd to me that a library standard that accepts year 17000000 does not accept years -999 through 999. But I think they do, just with leading zeroes, per ISO 8601?
Interesting (to me) was the Wikipedia page on ISO 8601:
ISO 8601 prescribes, as a minimum, a four-digit year [YYYY] to avoid the year 2000 problem. It therefore represents years from 0000 to 9999, year 0000 being equal to 1 BC and all others AD, similar to astronomical year numbering. However, years before 1583 (the first full year following the introduction of the Gregorian calendar) are not automatically allowed by the standard. Instead, the standard states that "values in the range [0000] through [1582] shall only be used by mutual agreement of the partners in information interchange".[19]
This seems very relevant to cultural heritage institutions.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: N/A
To quote myself:
What does this Pull Request do?
Puts back check for four+ digit years.
What's new?
(i.e. Regeneration activity, etc.)? No
How should this be tested?
Tests pass. 👍
Interested parties
@Islandora/committers